Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bull Bitcoin to case studies page #161

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 5, 2023

This PR adds Bull Bitcoin and BitMask to the case studies page.

cc @BullishNode
cc @cryptoquick

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 1818264
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/6536c81c0cb3f70008d9067e
😎 Deploy Preview https://deploy-preview-161--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielabrozzoni
Copy link
Member

This looks really good! A couple of nits:

  • At the moment bitmask is out of center, I think we should use a 1:1 logo (similar to the mutiny one, with a transparent border on top and bottom)

Selection_230

  • Doesn't have to be fixed here, but maybe the icons of the projects should have a max size? From desktop they look quite big, compared to, for example, the ldk website:
    Selection_229
    Selection_228

@ConorOkus
Copy link
Collaborator

@thunderbiscuit great job on getting this in. I'd just say try to optimize the images to be something like 130*130. That's what we have over on the LDK side anyway

@thunderbiscuit
Copy link
Member Author

Thank you for the comments!

This PR now fixes the size of the images, the length of some of the taglines, and adds the 2 new projects.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ACK b56cf15

@thunderbiscuit thunderbiscuit merged commit 1818264 into bitcoindevkit:master Oct 23, 2023
4 of 5 checks passed
@thunderbiscuit thunderbiscuit deleted the case-studies-2 branch January 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants